[ES|QL] use lexer from elasticsearch#178257
Merged
drewdaemon merged 1 commit intoelastic:mainfrom Mar 8, 2024
Merged
Conversation
drewdaemon
changed the title
Contributor
Author
|
/ci |
drewdaemon
added
release_note:skip
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
stratoula
reviewed
Mar 8, 2024
stratoula
approved these changes
Mar 8, 2024
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
I am super happy for this change! LGTM! Thanx Drew
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #173817
Up till now, we had to define our own lexer rules for our client-side ES|QL validation. This was because we were using an unofficial ANTLR package (before the official ANTLR had typescript support).
Now that we are using the official ANTLR library (as of #177211), we no longer have to encode case insensitivity into the lexer rules themselves because the
caseInsensitiveoption is now available to us.This means we can adopt the very same definitions that Elasticsearch uses as long as we set
caseInsensitive(Elasticsearch handles case insensitivity at runtime).Checklist